firstParty/native flag for elixir/erlang/go #4916
Conversation
There was a problem hiding this comment.
Thanks for taking a look into this, note that there are many you marked as first party that aren't. I tagged some of them but not all.
A first party instrumention is given if and only if the instrumented library and the instrumentation library are created by the same party
A native instrumentation is given if and only if the instrumented library does not need an external instrumentation library and comes with otel out of the box.
| @@ -14,3 +14,4 @@ authors: | |||
| urls: | |||
| repo: https://github.com/dubonzi/otelresty | |||
| createdAt: 2023-07-13 | |||
| isFirstParty: true | |||
There was a problem hiding this comment.
| isFirstParty: true | |
| isFirstParty: false |
| repo: https://go.opentelemetry.io/contrib/instrumentation/github.com/gocql/gocql | ||
| createdAt: 2022-12-07 | ||
| isFirstParty: true |
There was a problem hiding this comment.
that repo URL is incorrect, but also I don't think this is first party
There was a problem hiding this comment.
What would be the correct URL? And how do you find it?
| repo: https://go.opentelemetry.io/contrib/instrumentation/github.com/bradfitz/gomemcache | ||
| createdAt: 2022-12-07 | ||
| isFirstParty: true |
There was a problem hiding this comment.
that repo URL is incorrect, but also I don't think this is first party
There was a problem hiding this comment.
What would be the correct URL and how do you find it?
|
@haidong please take a look |
working on it now. Should be able to resolve your questions today. |
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
|
Thank you, @svrnm ! I accepted your suggestions one by one first in the Conversation tab. I then found I could do it in bulk at Files Changes tab, which is what I did to the rest of your suggestions. Please take a look again. |
|
/fix:all |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10809519051 |
|
IMPORTANT: (RE-)RUN
|
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
Please let me know if I can help in resolving the remaining conflicts. Thanks! |
those files have been deleted, since Go SIG is no longer maintaining them, so to resolve the conflict work on your PR locally, merge from main and make sure those fails stay removed. |
To address open-telemetry#4795, this is part of a series of PRs that add isFirstParty or isNative flags to instrumentation registries that lack them. This batch touches Elixir, Erlang, and Go instrumentation registries.
Done. Please review when convenient. Thanks @svrnm |
|
I noticed the Links / REFCACHE updates error. Following the suggestion, I ran Help please, thanks! PS. After reading https://opentelemetry.io/docs/contributing/pr-checks/, I ran |
|
/fix:all |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10865154166 |
|
IMPORTANT: (RE-)RUN
|
|
/fix:all |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10871784541 |
|
IMPORTANT: (RE-)RUN
|
|
Thanks so much @svrnm for your feedback and patience. If you have no objections, I'll proceed with the rest instrumentations. I'll once again do it in batches, a few programming languages at a time, so the number of files touched won't be overwhelming. |
To address #4795, this is part of a series of PRs that add isFirstParty or isNative flags to instrumentation registries that lack them.
This batch touches Elixir, Erlang, and Go instrumentation registries.
There are a number of repos that belong to individual maintainer as opposed to a corp/foundation entity. Please point out any errors and I will correct.
Oh, about where I placed the line: if there is a
package:line, then the flag is placed right above it. Otherwise, I placed it under thecreatedAt:line, which makes it usually the last non empty line of the file. I did it this way before I observed this pattern in other files before modifications.Thanks!